Skip to content

use the CVO to create the operator config#396

Closed
deads2k wants to merge 1 commit intoopenshift:masterfrom
deads2k:use-cvo-for-operator
Closed

use the CVO to create the operator config#396
deads2k wants to merge 1 commit intoopenshift:masterfrom
deads2k:use-cvo-for-operator

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Apr 12, 2019

The CVO supports create-only resources now, so we can use the CVO instead writing our own code a dozen times.

/assign @damemi

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 12, 2019
@damemi
Copy link
Copy Markdown
Contributor

damemi commented Apr 12, 2019

/lgtm

farewell old friend

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 12, 2019

/retest

6 similar comments
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 12, 2019

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 12, 2019

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 13, 2019

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 13, 2019

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 13, 2019

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 14, 2019

/retest

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 15, 2019

/test all

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 15, 2019

needs openshift/installer#1561

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 15, 2019

/hold

missing logs

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2019
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 16, 2019

/retest

1 similar comment
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 17, 2019

/retest

@damemi damemi mentioned this pull request Apr 17, 2019
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 17, 2019

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws e56dfd7 link /test e2e-aws
ci/prow/e2e-aws-operator e56dfd7 link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k closed this Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

Assignees

@damemi damemi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deads2k @damemi @openshift-ci-robot